[Form] Fixed few issues with Date and Time #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TimeType: - seconds are no longer populated if "with_seconds" = false - "widget = text" is now properly rendered (closes symfony#1480) * DateTimeToStringTransformer: - fixed using not default "format" (probably fix symfony#1183) * DateType, DateTimeType, TimeType: - fixed "input = datetime" and test covered - a bit changed readability
| @@ -101,15 +109,26 @@ class DateTimeType extends AbstractType | |||
|
|
|||
| if ($options['input'] === 'string') { | |||
| $builder->appendNormTransformer(new ReversedTransformer( | |||
| new DateTimeToStringTransformer($options['data_timezone'], $options['data_timezone'], $format) | |||
| new DateTimeToStringTransformer( | |||
| $options['data_timezone'], | |||
There was a problem hiding this comment.
Can you revert this kind of changes? Thanks.
There was a problem hiding this comment.
IMO this make code a bit more readable, but reverted it ;-)
| $dateTime = new \DateTime($value, new \DateTimeZone($this->outputTimezone)); | ||
|
|
||
| // Force value to be in same format as given to transform | ||
| if ($value !== $dateTime->format($this->format)) { |
There was a problem hiding this comment.
I don't understand this piece of code. What are you trying to do?
fabpot
added a commit
that referenced
this pull request
Jul 4, 2011
Commits ------- 3917ed7 Revert "* DateType, DateTimeType, TimeType: - a bit changed readability" c85b815 Fixed few issues with Date and Time: Discussion ---------- [Form] Fixed few issues with Date and Time Fixed few issues with Date and Time: * TimeType: - seconds are no longer populated if "with_seconds" = false - "widget = text" is now properly rendered (closes #1480) * DateTimeToStringTransformer: - fixed using not default "format" (probably fix #1183) * DateType, DateTimeType, TimeType: - fixed "input = datetime" and test covered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed few issues with Date and Time: