[profiler][request toolbar] Removed route name from the toolbar #14903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
3 similar comments
|
👍 |
|
👍 |
|
👍 |
|
👍 we can remove |
|
I'm against removing the Controller and Action suffixes as they are not required, just conventions people can follow. |
|
👍 |
|
Thank you @MJBGO. |
fabpot
added a commit
that referenced
this pull request
Jun 8, 2015
…e toolbar (MJBGO) This PR was merged into the 2.8 branch. Discussion ---------- [profiler][request toolbar] Removed route name from the toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14744 | License | MIT | Doc PR | The action block takes nearly 1/3 of the bar width which is not good. The controller + action names are useful but the route name less important. Before  After  The route name is shown by hovering the action block  Commits ------- 9004e29 Removed route name from the debugbar.
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…from the toolbar (MJBGO) This PR was merged into the 2.8 branch. Discussion ---------- [profiler][request toolbar] Removed route name from the toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#14744 | License | MIT | Doc PR | The action block takes nearly 1/3 of the bar width which is not good. The controller + action names are useful but the route name less important. Before  After  The route name is shown by hovering the action block  Commits ------- 9004e29 Removed route name from the debugbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action block takes nearly 1/3 of the bar width which is not good.
The controller + action names are useful but the route name less important.
Before
After
The route name is shown by hovering the action block
