[2.8][Filesystem] Changed dumpFile to allow dumping to streams... #14970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive tempnam() and fixed dumpFile to allow dumping to streams
This was referenced Jun 13, 2015
|
Hi @xabbuh, Are there any further actions needed on this before it can be merged? Thanks |
| $tmpFile = tempnam($hierarchy, $prefix); | ||
|
|
||
| // If tempnam failed or no scheme return the filename otherwise prepend the scheme | ||
| return false === $tmpFile || null === $scheme ? $tmpFile : $scheme.'://'.$tmpFile; |
There was a problem hiding this comment.
I think it would be better to throw an exception if an error occurred instead of silently fail and return a magic return value (same below).
|
@markchalloner Are you still interested in finishing this PR? |
|
@fabpot. Sure |
| @@ -30,11 +30,15 @@ $filesystem->rename($origin, $target); | |||
|
|
|||
| $filesystem->symlink($originDir, $targetDir, $copyOnWindows = false); | |||
|
|
|||
| $filesystem->tempnam($dir, $prefix); | |||
There was a problem hiding this comment.
should be removed as we only document "major" features in READMEs.
|
@fabpot Thanks for the feedback. On reflection I am happy to pass this over to anyone who wants to pick this up, unfortunately I don't currently have the time to dedicate to this. |
|
Thanks for your feedback @markchalloner I'm closing this PR. Someone can take over anytime by finishing this PR. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2015
…ams (markchalloner, pierredup) This PR was merged into the 2.8 branch. Discussion ---------- [Filesystem] Changed dumpFile to allow dumping to streams | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10018 | License | MIT | Doc PR | symfony/symfony-docs#5393 This is a follow-up of #14970 with comments addressed Commits ------- 5ca7dee Fix mode a17aa5e Fixed failing test for HHVM 61a3afd Removed unused logic in MockStream 247266c Update coding standard for MockStream c6a7747 [Filesystem] added tempnam() stream wrapper aware version of PHP's native tempnam() and fixed dumpFile to allow dumping to streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as rename can only work where $oldname and $newname have the same streams wrappers.
Added tempnam, stream wrapper aware version of tempnam(), to do the heavy lifting.