[2.8] Make service not shared when prototype scope is set #15091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Tests should be fixed now as well :) |
|
👍 |
| @@ -33,6 +33,6 @@ | |||
| <configurator class="%baz_class%" method="configureStatic1"/> | |||
| </service> | |||
| <service id="factory_service" class="Bar" factory-method="getInstance" factory-service="foo.baz"/> | |||
| <service id="foo_bar" class="%foo_class%" scope="prototype"/> | |||
| <service id="foo_bar" class="%foo_class%" shared="false" scope="prototype"/> | |||
There was a problem hiding this comment.
Do we need the additional prototype attribute?
There was a problem hiding this comment.
this is to test the output of the XmlDumper. As this service is a legacy service, it only sets the scope to prototype (which remains the same). The only thing this PR changed was also setting shared to false in these cases
|
@fabpot btw, do you think that we need to keep the correct |
|
And shouldn't we add a dedicated test for this to avoid regressions? |
|
@xabbuh Yes, we need a test to avoid regressions |
|
👍 with an additional test |
|
Added a very simple legacy test |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @wouterj. |
Tobion
added a commit
that referenced
this pull request
Jun 24, 2015
…t (WouterJ) This PR was merged into the 2.8 branch. Discussion ---------- [2.8] Make service not shared when prototype scope is set | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Deprecating the scopes was introducing a BC break in Symfony 2.8 when using the prototype scope. As `$shared` wasn't updated if the scope was set to `prototype`, people will always get an error because of [the `CheckDefinitionValidityPass`](https://github.com/symfony/DependencyInjection/blob/04d5d925a987f35854f51b1c468c0ca81e1d61b9/Compiler/CheckDefinitionValidityPass.php#L54-L57). Commits ------- b7030cc Make service not shared when prototype scope is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating the scopes was introducing a BC break in Symfony 2.8 when using the prototype scope. As
$sharedwasn't updated if the scope was set toprototype, people will always get an error because of theCheckDefinitionValidityPass.