[2.8][DependencyInjection] improve deprecation messages #15113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also include the service id in the deprecation message.
|
IMO we should do the same with the Edit: Sorry, #15112 do this. |
|
👍 |
|
👍 |
| @@ -162,7 +162,7 @@ private function parseDefinition(\DOMElement $service, $file) | |||
| $triggerDeprecation = 'request' !== (string) $service->getAttribute('id'); | |||
|
|
|||
| if ($triggerDeprecation) { | |||
| @trigger_error(sprintf('The "scope" attribute in file "%s" is deprecated since version 2.8 and will be removed in 3.0.', $file), E_USER_DEPRECATED); | |||
| @trigger_error(sprintf('The "scope" attribute of service "%s" in file "%s" is deprecated since version 2.8 and will be removed in 3.0.', (string) $service->getAttribute('id'), $file), E_USER_DEPRECATED); | |||
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 27, 2015
…(xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [2.8][DependencyInjection] improve deprecation messages | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Also include the service id in the deprecation message. Commits ------- d144dbb [DependencyInjection] improve deprecation messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include the service id in the deprecation message.