bug #15118 [Filesystem] mirroring a symlink copies absolute file path #15119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the test failures are the fault of this PR... they seem to be completely unrelated. |
|
2.5 end of support for bug fixes is reached since January, so I think this should go to the 2.6 branch (which end of support for bug fixes is July). You can consult the version checker here: https://symfony.com/roadmap?version=2.5#checker. Also, this certainly explains the failing tests with high dependencies. |
|
Thanks for the tip. #15121 replaces this for 2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the code change in a8b8d33 and adjusting the test case accordingly.
I hope I opened this against the correct branch- this bug exists in version 2.5 through 2.8, so I think the fix should be applied to 2.5 first? This is my first contribution to symfony so I welcome any feedback.