Skip to content

[Form][Type Date/Time] added choice_translation_domain option. #15301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Form][Type Date/Time] added choice_translation_domain option. #15301

wants to merge 2 commits into from

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #15222 and #15298
License MIT
  • add test

@aitboudad aitboudad mentioned this pull request Jul 17, 2015
Closed
@MacDada
Copy link
Contributor

MacDada commented Jul 17, 2015

Will this be backported to 2.7?

Tobion
Tobion reviewed Jul 17, 2015
View reviewed changes
src/Symfony/Component/Form/Extension/Core/Type/DateType.php
if (is_array($choiceTranslationDomain)) {
$default = false;

return array_merge(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semantically you want array_replace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Tobion
Copy link
Contributor

Tobion commented Jul 17, 2015

Related to #9177

@aitboudad aitboudad force-pushed the choice_translation_domain_date_time branch 2 times, most recently from fe789c5 to f883892 Compare August 7, 2015 16:03
@aitboudad
Copy link
Contributor Author

test added.

@aitboudad aitboudad mentioned this pull request Aug 18, 2015
Closed
@aitboudad aitboudad force-pushed the choice_translation_domain_date_time branch from f883892 to 25b0be4 Compare August 27, 2015 09:25
@aitboudad aitboudad force-pushed the choice_translation_domain_date_time branch from 25b0be4 to 42458a5 Compare September 14, 2015 09:04
@aitboudad aitboudad force-pushed the choice_translation_domain_date_time branch from 42458a5 to 67da7ef Compare September 16, 2015 14:58
@Tobion
Copy link
Contributor

Tobion commented Sep 18, 2015

👍 Good to merge IMO.

@fabpot
Copy link
Member

fabpot commented Sep 18, 2015

Should it be considered as a new feature?

@Tobion
Copy link
Contributor

Tobion commented Sep 18, 2015

IMO yes as it doesn't fix a real bug but only tries to reduce missing translation warnings (warnings are not bugs).

@Tobion Tobion mentioned this pull request Sep 26, 2015
Closed
@stof
Copy link
Member

stof commented Sep 26, 2015

👍

@Tobion
Copy link
Contributor

Tobion commented Sep 26, 2015

Thank you @aitboudad.

@Tobion Tobion closed this in 3909460 Sep 26, 2015
@aitboudad aitboudad deleted the choice_translation_domain_date_time branch September 27, 2015 11:40
@jvasseur jvasseur mentioned this pull request Oct 2, 2015
Closed
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Form Ready Status: Reviewed Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aitboudad @MacDada @Tobion @fabpot @stof @carsonbot