[Debug] Deprecate ExceptionHandler::createResponse #15418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -154,8 +154,7 @@ public function handle(\Exception $exception) | |||
| * | |||
| * @param \Exception $exception An \Exception instance | |||
| * | |||
| * @see sendPhpResponse() | |||
| * @see createResponse() | |||
| * @deprecated since 2.8, to be removed and replaced by a direct call to sendPhpResponse in 3.0. | |||
There was a problem hiding this comment.
deprecating a private method looks weird. You should describe what is deprecated exactly
|
Or could I drop this method in 2.7? The comments in #5367 make me think that the answer could be yes. |
This was referenced Jul 31, 2015
Closed
134ff15 to
e287a6b
Compare
e505e1e to
1bb4f44
Compare
1bb4f44 to
dfe0356
Compare
|
PR is ready but is to be merged after #15417 (which is included for now) |
a0dfe87 to
1782bfd
Compare
|
Ok, can you rebase then? |
1782bfd to
a4d2d31
Compare
|
Rebased |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 1, 2015
…colas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [Debug] Deprecate ExceptionHandler::createResponse | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #15414 | License | MIT | Doc PR | - This does deprecate a behavior that might be specialized by someone somewhere, but I seriously doubt anyone did. It complicated the implementation for no gain IMHO. Commits ------- a4d2d31 [Debug] Deprecate ExceptionHandler::createResponse
Merged
fabpot
added a commit
that referenced
this pull request
Nov 26, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [Debug] remove unused use statement | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ref #15418 Commits ------- a862e5e [Debug] remove unused use statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does deprecate a behavior that might be specialized by someone somewhere, but I seriously doubt anyone did. It complicated the implementation for no gain IMHO.