[Twig][Bridge] force space between widget and label in checkbox_radio_label #15446
Conversation
|
I don't know anything about xpath but I think it's not normal tests fail because of one space. |
|
@MatTheCat it is normal, because this XPath query asserts the text of the label, and you now have a space in it which was not there before |
|
Should we use |
|
I think you should add the space in the test. If we used |
|
I don't get why tests are failing past PHP5.5 =/ |
|
@xabbuh thus it would not work. @MatTheCat we have an issue with the deps=low and deps=high tests. @nicolas-grekas is currently working on fixing them. |
|
👍 |
| @@ -168,8 +168,7 @@ | |||
| {% set label = name|humanize %} | |||
| {% endif %} | |||
| <label{% for attrname, attrvalue in label_attr %} {{ attrname }}="{{ attrvalue }}"{% endfor %}> | |||
| {{- widget|raw -}} | |||
| {{- label is not sameas(false) ? label|trans({}, translation_domain) -}} | |||
| {{- widget|raw }} {{ label is not sameas(false) ? label|trans({}, translation_domain) -}} | |||
There was a problem hiding this comment.
Should be same as now that sameas is deprecated.
There was a problem hiding this comment.
Should this be made in this PR?
There was a problem hiding this comment.
Never mind, this has been fixed in the meantime in 99a1fcc.
|
Thank you @MatTheCat. |
…ckbox_radio_label (MatTheCat) This PR was submitted for the 2.6 branch but it was merged into the 2.7 branch instead (closes #15446). Discussion ---------- [Twig][Bridge] force space between widget and label in checkbox_radio_label | Q | A | ------------- | --- | Fixed tickets | N/A | License | MIT Update  to  Commits ------- ed9c610 [Twig][Bridge] force space between widget and label in checkbox_radio_label
Update
to