Fix BC break after split of ACL component #15520
Conversation
|
👍 this should fix the issue where people depending on |
|
This should not propagate up to master and we should instead tell people to add this dep explicitly in UPGRADING |
|
@nicolas-grekas I agree, this should be a I have made a start on the acl bundle as well. I might have to add this bundle in the same fashion to this |
|
In fact, I worked around this BC break in 1270e72 (same on me I did it silently :) ) |
This PR was merged into the 2.8 branch. Discussion ---------- Fix BC break after split of ACL from core Rebased version of #15520 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7e9991e Fix BC break after split of ACL from core
Conflicts: CHANGELOG-2.3.md CHANGELOG-2.7.md composer.json src/Symfony/Bridge/Twig/composer.json src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Bundle/SecurityBundle/composer.json src/Symfony/Component/Console/Tests/Helper/LegacyProgressHelperTest.php src/Symfony/Component/Console/Tests/Helper/LegacyTableHelperTest.php src/Symfony/Component/Console/composer.json src/Symfony/Component/DomCrawler/composer.json src/Symfony/Component/Form/Tests/FormRegistryTest.php src/Symfony/Component/Form/composer.json src/Symfony/Component/HttpFoundation/composer.json src/Symfony/Component/HttpKernel/Tests/Profiler/MongoDbProfilerStorageTest.php src/Symfony/Component/Intl/composer.json src/Symfony/Component/Ldap/composer.json src/Symfony/Component/Security/Core/composer.json src/Symfony/Component/Security/Csrf/composer.json src/Symfony/Component/Security/Http/composer.json src/Symfony/Component/Security/composer.json src/Symfony/Component/Serializer/Encoder/JsonEncoder.php src/Symfony/Component/Serializer/composer.json src/Symfony/Component/Templating/PhpEngine.php src/Symfony/Component/Translation/composer.json src/Symfony/Component/VarDumper/Tests/HtmlDumperTest.php src/Symfony/Component/VarDumper/composer.json
Until symfony 3.0, the ACL component should still be included in Symfony to avoid BC breaks.
I don't think we can trigger deprecation errors here to warn people that they have to include an extra require.