[Translator][fallback catalogues] fixed circular reference. #15527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Aug 12, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | ~ |
| Tests pass? | yes |
| License | MIT |
559baab to
ea9c63d
Compare
|
This fixes issue #15522 |
ea9c63d to
79e29c1
Compare
|
@symfony/deciders can someone review please :) |
|
what happens if you defined |
|
@stof |
|
well, this looks weird to me though, as the fr fallback of en will be different from the fr catalogue used anywhere else. But it is indeed one of the possible implementations. the other one could be to consider that Anyway it is a different topic (and a behavior change, so not for 2.3), so it should be discussed separately. 👍 for this |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Sep 2, 2015
…. (aitboudad) This PR was merged into the 2.3 branch. Discussion ---------- [Translator][fallback catalogues] fixed circular reference. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT Commits ------- 79e29c1 [Translator][fallback catalogues] fixed circular reference.
|
I believe this caused a regression: #17596 |
fabpot
added a commit
that referenced
this pull request
Jan 31, 2016
… catalogue (c960657) This PR was merged into the 2.3 branch. Discussion ---------- [Translation] Add resources from fallback locale to parent catalogue | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The resources representing a locale includes those of the fallback locale. However, `getCatalogue()->getResources()` only returns the resources belonging specifically to the selected locale. Example: The locale `en_GB` falls back to `en`. I use the locale `en_GB`. During development, when I modify the `en_GB` translation file, the changes appear instantly when reloading the page. If I modify the `en` translation file, I need to manually clear the cache in order for the new translation to appear. I believe this is a regression that was introduced in #15527. This patch is for the 2.3 branch. For 2.6 and later, the test can be updated to use the getCatalogue() method instead of using ReflectionProperty. Commits ------- f7f82fa [Translation] Add resources from fallback locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.