Skip to content

[travis] make the PHP version check for APC more robust #15616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[travis] make the PHP version check for APC more robust #15616

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 25, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas
Copy link
Member

Does this fix anything?

@wouterj
Copy link
Member

wouterj commented Aug 25, 2015

@nicolas-grekas the current way means APC is configured for the 7.0 builds as well IIUC

@nicolas-grekas
Copy link
Member

@wouterj not really because of the first if in the bash line

@vicb
Copy link
Contributor Author

vicb commented Aug 25, 2015

PHP7 was what I had in mind when submitting this PR.

Releasing good SW is also about promoting good practices and IMO checking minor version number only is not one of them. However I could understand if you prefer closing this PR & feel free to do so.

@nicolas-grekas
Copy link
Member

Thanks @vicb see .travis.yml in #15575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vicb @nicolas-grekas @wouterj @carsonbot