[WIP] #15502 Make template shortcuts be usable without Templating component #15620
Conversation
Koc
commented
Aug 26, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | ? |
| Fixed tickets | #15502 |
| License | MIT |
| Doc PR | - |
|
You should add this change to the CHANGELOG.md |
|
👍 |
|
👍 but some tiny tests to ensure these methods keep being called would be good. |
|
@Tobion can you give advice, maybe some piece of code how to do this? Bootstrap kernel without templating - where should I do it? |
|
I don't mean functional tests but unit tests. We already have unit tests for this class. Just mock the container and ensure the methods are called. |
| $twig = $this->container->get('twig'); | ||
|
|
||
| $callback = function () use ($twig, $view, $parameters) { | ||
| $twig->loadTemplate($view)->display($parameters); |
There was a problem hiding this comment.
use $twig->display() here rather than the internal implementation
There was a problem hiding this comment.
loadTemplate() is public, so it's not internal
There was a problem hiding this comment.
But what's the point of using the more verbose version?
There was a problem hiding this comment.
one less method call ;)
doesn't really matter to me. I'm fine with both
|
And if the if ($this->container->has('templating')) {
// use the templating component
} else if ($this->container->has('twig')) {
// use twig
} else {
throw new \LogicException('You can not use the XXX method if the Templating Component or the Twig Bundle are not available.');
} |
|
Thank you @Koc. |
|
I've reverted the tests |