[3.0] Various deprecation removal #15685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Sep 3, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
519bb44 to
08c9054
Compare
08c9054 to
b1f3d52
Compare
|
LGTM 👍 Edit. Oops :) |
| * | ||
| * @deprecated Deprecated since version 2.8, to be removed in 3.0. | ||
| */ | ||
| public function cannotBeEmpty() |
There was a problem hiding this comment.
As I understand correctly - after removing this overridion, calling this method just executes from parent class without any error?
There was a problem hiding this comment.
Wasn't this supposed to throw an exception ? (see this message)
There was a problem hiding this comment.
@Ener-Getick please open an issue to get an answer
|
👍 |
|
Status: Reviewed |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 6, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] Various deprecation removal | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- b1f3d52 [3.0] Various deprecation removal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.