[2.8][Translator] Added missing changelog notes. #15698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Sep 5, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | ~ |
| Tests pass? | yes |
| License | MIT |
| @@ -4,8 +4,10 @@ CHANGELOG | |||
| 2.8.0 | |||
| ----- | |||
|
|
|||
| * deprecated Translator::getMessages(), use TranslatorBagInterface::getCatalogue() instead. | |||
| * added options 'as_tree', 'inline' to YamlFileDumper | |||
| * deprecated Translator::getMessages(), rely into TranslatorBagInterface::getCatalogue() instead. | |||
33bce92 to
461e595
Compare
| @@ -290,11 +290,11 @@ protected function getLoaders() | |||
| * | |||
| * @return array[array] indexed by catalog | |||
| * | |||
| * @deprecated since version 2.8, to be removed in 3.0. Use TranslatorBagInterface::getCatalogue() method instead. | |||
| * @deprecated since version 2.8, to be removed in 3.0. Rely on TranslatorBagInterface::getCatalogue() method instead. | |||
There was a problem hiding this comment.
We always use Use ... instead in deprecation messages. I don't think this change is worth.
There was a problem hiding this comment.
it was suggested by stof see #14546 (comment)
There was a problem hiding this comment.
Then we would need to change it in many places. Many things are not drop-in replacements. Will be pretty hard to change it everywhere. Thus not worth.
Also use doesn't imply a drop-replacement at all.
There was a problem hiding this comment.
it's ok for me, reverted!
461e595 to
2592fe9
Compare
|
Thank you @aitboudad. |
Tobion
added a commit
that referenced
this pull request
Sep 5, 2015
…dad) This PR was merged into the 2.8 branch. Discussion ---------- [2.8][Translator] Added missing changelog notes. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT Commits ------- 2592fe9 [Translator] Added missing changelog notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.