added ExceptionHandler::getHtml() to expose the full HTML of an exception #15710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and now, we remember why |
| /** | ||
| * Gets the full HTML content associated with the given exception. | ||
| * | ||
| * @param \Exception|FlattenException $exception An \Exception instance |
There was a problem hiding this comment.
the argument description is wrong in case a FlattenException is passed
1d27717 to
4d1d277
Compare
fabpot
added a commit
that referenced
this pull request
Sep 7, 2015
…TML of an exception (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- added ExceptionHandler::getHtml() to expose the full HTML of an exception | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a `ExceptionHandler::createResponse()` has been deprecated in 2.8 to remove the HttpFoundation dependency on `symfony/debug`. But that breaks Silex which relies on this method. As the `decorate` method is private, there is no way in Silex to upgrade. Instead of making the `decorate()` method public, I propose to add a new `getHtml()` method that returns the exception as a full HTML page. Commits ------- 4d1d277 added ExceptionHandler::getHtml() to expose the full HTML of an exception
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExceptionHandler::createResponse()has been deprecated in 2.8 to remove the HttpFoundation dependency onsymfony/debug. But that breaks Silex which relies on this method. As thedecoratemethod is private, there is no way in Silex to upgrade. Instead of making thedecorate()method public, I propose to add a newgetHtml()method that returns the exception as a full HTML page.