[Translator][Loader] added XLIFF 2.0 support. #15717
Conversation
aitboudad
commented
Sep 7, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #11853, #12853 |
| Tests pass? | yes |
| License | MIT |
| // simple_xml will always return utf-8 encoded values | ||
| $target = $this->utf8ToCharset((string) (isset($translation->target) ? $translation->target : $source), $encoding); | ||
|
|
||
| $catalogue->set((string) $source, $target, $domain); |
There was a problem hiding this comment.
support for notes and target attributes should be added for XLiff 2 for the equivalent features
There was a problem hiding this comment.
ok I'll look into it
There was a problem hiding this comment.
I only added support for target attributes
but for notes there's no way to do a mapping because aren't assigned to specific segments, but to whole units.
There was a problem hiding this comment.
@stof what do you think to take account of notes only when a unit contains one segment and ignore other cases ?
<unit id="1">
<notes>
<note priority="1" appliesTo="target">foo</note>
</notes>
<segment>
<source>foo</source>
<target>foo</target>
</segment>
</unit>| use Symfony\Component\Config\Resource\FileResource; | ||
| use Symfony\Component\Translation\Loader\XliffFileLoader; |
There was a problem hiding this comment.
Symfony use the ordered use statements?
Otherwise i would revert this line
There was a problem hiding this comment.
Indeed, we do not re-sort existing use statements to avoid merging issues
|
Support for Xliff2 should also be added in the dumper |
|
should we have support for |
|
@stof we can add support for Ping @symfony/deciders |
|
👍 |
|
Thank you @xphere. |
… aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [Translator][Loader] added XLIFF 2.0 support. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | #11853, #12853 | Tests pass? | yes | License | MIT Commits ------- 0c24d55 [Translation][Dumper] added XLIFF 2.0 support. 7af4fc7 [XLIFF 2.0] added support for target attributes. ace6042 apply some fixes. ce540ae update changelog. ff5d6a3 [Translation][Loader] added XLIFF 2.0 support.