[HttpKernel] Move required RequestStack args as first arguments #15724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93542ff to
e780488
Compare
|
deps=high failures will be fixed once this PR is merged into master |
|
See #15196 |
819c5e8 to
d106c1b
Compare
d106c1b to
84ba05b
Compare
|
I still don't get why we should make such changes. It would make impossible/very hard to support all Symfony versions in Silex for instance. |
|
@fabpot because we have these comments that say: |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 10, 2015
…arguments (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpKernel] Move required RequestStack args as first arguments | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Since we planned to make RequestStack required, we have to move it as first arguments. Commits ------- 84ba05b [HttpKernel] Move required RequestStack args as first arguments
|
We should document this in the upgrade file for Symfony 2.8. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we planned to make RequestStack required, we have to move it as first arguments.