Skip to content

Using a service as a router resource #15742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Using a service as a router resource #15742

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b6b2cc8
Adding a new route loader that is able to load routes from a service
weaverryan Sep 9, 2015
423f6b0
Registering the route loader as a service
weaverryan Sep 9, 2015
ca1229f
fabbot!
weaverryan Sep 9, 2015
cf7af64
Moving the ServiceRouteLoader stuff into the Routing component as an …
weaverryan Sep 10, 2015
5d34c96
Some tweaks thanks to @jakzal
weaverryan Sep 10, 2015
c129cdd
Hinting against the interface
weaverryan Sep 10, 2015
8440be2
Adding the entire class hierarchy as a resource
weaverryan Sep 13, 2015
2bb0adc
Fixing typo
weaverryan Sep 14, 2015
ee90412
Fixing comment typo
weaverryan Sep 22, 2015
de4143a
Fixing test - bad mock
weaverryan Sep 24, 2015
eb47a69
Fixing bad mock of "abstract" class
weaverryan Sep 26, 2015
3cb24eb
Changing this to be an abstract ObjectRouteLoader
weaverryan Sep 30, 2015
e431fc7
Adding a ServiceRouterLoader that works with the DependencyInjection …
weaverryan Sep 30, 2015
43e9ad2
Renaming abstract method and going back to the key "service" as the type
weaverryan Sep 30, 2015
7ed22ce
fabbot
weaverryan Sep 30, 2015
6b0a5c6
Updating ObjectRouteLoader to use a service_id:methodName format
weaverryan Oct 1, 2015
a4af474
updating CHANGELOG
weaverryan Oct 1, 2015
a2cb797
Fixing missing gettype
weaverryan Oct 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing missing gettype
  • Loading branch information
@weaverryan
weaverryan committed Oct 1, 2015
commit a2cb79716a5a53bafb38c6e9cd79cab3ffc2530c
2 changes: 1 addition & 1 deletion src/Symfony/Component/Routing/Loader/ObjectRouteLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function load($resource, $type = null)
$loaderObject = $this->getServiceObject($serviceString);

if (!is_object($loaderObject)) {
throw new \LogicException(sprintf('%s:getServiceObject() must return an object: %s returned', get_class($this), $loaderObject));
throw new \LogicException(sprintf('%s:getServiceObject() must return an object: %s returned', get_class($this), gettype($loaderObject)));
}

if (!method_exists($loaderObject, $method)) {
Expand Down