[Translation] added option json_options to JsonFileDumper. #15756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,9 +23,23 @@ class JsonFileDumper extends FileDumper | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| protected function formatCatalogue(MessageCatalogue $messages, $domain, array $options = array()) | |||
| { | |||
| if (isset($options['json_encoding'])) { | |||
There was a problem hiding this comment.
maybe call this json_flags or json_options?
There was a problem hiding this comment.
json_flags sound good to me
There was a problem hiding this comment.
but can we take on #14750 (comment) ?
There was a problem hiding this comment.
OK, then fine for json_encoding...
There was a problem hiding this comment.
reverted, thanks!
|
👍 |
| @@ -30,7 +30,19 @@ public function testDump() | |||
| $dumper->dump($catalogue, array('path' => $tempDir)); | |||
|
|
|||
| $this->assertEquals(file_get_contents(__DIR__.'/../fixtures/resources.json'), file_get_contents($tempDir.'/messages.en.json')); | |||
| unlink($tempDir.'/messages.en.json'); | |||
There was a problem hiding this comment.
this won't be unlinked in case of assertion failure. You should do it on teardown
It's passed to json_encode function second argument.
|
Thank you @gepo. |
aitboudad
added a commit
that referenced
this pull request
Sep 11, 2015
…per. (gepo) This PR was merged into the 2.8 branch. Discussion ---------- [Translation] added option json_options to JsonFileDumper. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | ~ | License | MIT | Doc PR | Replaces #14750 Commits ------- bfdc354 [Translation] added option flags to JsonFileDumper. It's passed to json_encode function second argument.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #14750