Introduction of syntax/shortcut aware Definition #15800
Conversation
…ntaxAwareContainerBuilder. The purpose is to allow for YAML-like @service_name shortcuts through PHP. The SyntaxAwareDefinition is the most important part of this, but the SyntaxAwareContainerBuilder is also important as it allows you to use the ContainerBuilder::register() fluent interface for adding these types of Definitions. The SyntaxAwareParameterBag completes the last use of the shortcuts - expression shortcuts inside parameters.
|
👎 from me. I still don't understand why creating a I'm all for making things simpler, but this one does not seem to go in the right direction. If we really want to make things "easier", and if a use statement or creating an object seems too complex, I would prefer to introduce a |
|
👎 We do not want to introduce magic again. The syntax for YAML only exists because there is no way to make it explicit as in PHP. |
| private function resolveServices($value) | ||
| { | ||
| if (is_array($value)) { | ||
| $value = array_map(array('self', 'resolveServices'), $value); |
There was a problem hiding this comment.
I would use a return here directly, which would allow to use if rather than elseif for next cases
|
-1 from me as well. Your SyntaxAwareDefinition violates SRP, which would break any compiler pass dealing with definitions later if it does not take care of it ( |
|
Thanks for the review - I'm convinced there's no solid technical way to accomplish this, even if we wanted to. Closing. |
Hi guys!
Similar to what #15778 does for routes, this aims to make creating Definitions in PHP easier. This is already quite easy, but this PR has 2 additional goals:
@service_namesyntax to be used with Definitions. Subjectively, this makes building services in PHP much more appearling:Also, this makes the PHP syntax very very close to the YAML syntax, make it easy to learn/teach if this were done more often, e.g in some micro/RAD edition.
ContainerBuilder::register()interface.Thanks!