Skip to content

[WebProfilerBundle] Make admin button consistent with others #15819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WebProfilerBundle] Make admin button consistent with others #15819

wants to merge 1 commit into from

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Sep 16, 2015

Q A
Bug fix? yes(?)
New feature? no
License MIT

@javiereguiluz
Copy link
Member

👎 from me. This feature is displayed as a link on purpose. It's a common practice to do that for this kind of secondary utilities in backend designs. Buttons are reserved for important things, and in my opinion this feature is not.

@stof
Copy link
Member

stof commented Sep 16, 2015

Wait, purging is a GET request ? This should be changed to a POST request IMO

@fabpot
Copy link
Member

fabpot commented Sep 26, 2015

I would even remove the feature from the web interface altogether. I've never used it myself and I'm pretty nobody uses it.

@javiereguiluz
Copy link
Member

I like the idea of removing this feature. Do other Symfony deciders agree on this?

@weaverryan
Copy link
Member

👍 for removing the feature. If you want to purge, you can do that by emptying whatever your storage is (and for most people, just clearing the cache).

@stof
Copy link
Member

stof commented Sep 26, 2015

I agree about the removal. I never purge it through the UI.

@xabbuh
Copy link
Member

xabbuh commented Sep 27, 2015

👍 for removing the feature

@javiereguiluz javiereguiluz mentioned this pull request Sep 27, 2015
Merged
@stloyd stloyd closed this Sep 27, 2015
@stloyd stloyd deleted the patch-1 branch September 27, 2015 18:21
fabpot added a commit that referenced this pull request Sep 28, 2015
@fabpot
feature #15939 Removed the "Delete profiles" action from the web prof…
32002d7 
…iler sidebar (javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Removed the "Delete profiles" action from the web profiler sidebar

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #15819
| License       | MIT
| Doc PR        | -

Commits
-------

8c47eb9 Removed the "Delete profiles" action from the web profiler sidebar
@sstok
Copy link
Contributor

sstok commented Oct 4, 2015

I have actually used this (trying to debug a redirect loop and needing the first request) :) but I'm OK with removing this 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stloyd @javiereguiluz @stof @fabpot @weaverryan @xabbuh @sstok @carsonbot