[Translation][File dumper] allow new child classes to implement only formatCatalogue #15832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Sep 18, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #15699 |
| Tests pass? | yes |
| License | MIT |
| abstract protected function format(MessageCatalogue $messages, $domain); | ||
| protected function format(MessageCatalogue $messages, $domain) | ||
| { | ||
| throw new \RuntimeException('The '.__METHOD__.' method needs to be implemented to use it.'); |
There was a problem hiding this comment.
a LogicException would be better (consistent with the way the Console component does such thing).
and the message is bad:
- it should not use
__METHOD__as the method should be implemented in the child class, while it showsFileDumper::formatin your case - the message is not accurate. It should tell to implement either format or formatCatalogue.
There was a problem hiding this comment.
changes have been applied.
2eca57b to
5fd9f2f
Compare
|
Thanks @aitboudad. |
Tobion
added a commit
that referenced
this pull request
Sep 18, 2015
…plement only formatCatalogue (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [Translation][File dumper] allow new child classes to implement only formatCatalogue | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #15699 | Tests pass? | yes | License | MIT Commits ------- 5fd9f2f [Translation][File dumper] allow new child classes to implement only formatCatalogue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.