[VarDumper] Add EnumStub for dumping virtual collections with casters #15837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Once tests are fixed of course |
e2b454c to
e1af8cc
Compare
e1af8cc to
aa50596
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 22, 2015
…ns with casters (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Add EnumStub for dumping virtual collections with casters | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Currently, casters may use arrays to represent a collection of virtual values. They are curently dumped the same as regular arrays, and this leads to noisy output (like the `array:%n` prefix, or the quotes around "keys"). This PR adds a new EnumStub for these situations. Here is an example when using PdoCaster: Before :  After:  Commits ------- aa50596 [VarDumper] Add EnumStub for dumping virtual collections with casters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, casters may use arrays to represent a collection of virtual values. They are curently dumped the same as regular arrays, and this leads to noisy output (like the
array:%nprefix, or the quotes around "keys").This PR adds a new EnumStub for these situations.
Here is an example when using PdoCaster:
Before :
After:
