Skip to content

[FrameworkBundle] Advanced search templates of bundles #15846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yethee
Copy link
Contributor

@yethee yethee commented Sep 20, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

It uses two different locations to search templates of bundle by TemplateFinder, as described in the documentation.

Useful for TwigBundle, in cases when uses the custom templates for error pages.

It uses two different locations to search templates of bundle,
as described in the documentation.
@sstok
Copy link
Contributor

sstok commented Sep 24, 2015

LGTM 👍

Status: Reviewed

@xabbuh
Copy link
Member

xabbuh commented Sep 26, 2015

👍

@fabpot
Copy link
Member

fabpot commented Sep 26, 2015

Thank you @yethee.

fabpot added a commit that referenced this pull request Sep 26, 2015
…thee)

This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #15846).

Discussion
----------

[FrameworkBundle] Advanced search templates of bundles

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

It uses two different locations to search templates of bundle by `TemplateFinder`, as described in the documentation.

Useful for TwigBundle, in cases when uses the custom templates for error pages.

Commits
-------

3ba1460 [FrameworkBundle] Advanced search templates of bundles
@fabpot fabpot closed this Sep 26, 2015
@yethee yethee deleted the template-finder branch September 26, 2015 22:46
@mfdj
Copy link

mfdj commented Oct 12, 2015

Any chance this fix could get back-ported to earlier versions? I could benefit from this change in a current project that uses symfony 2.7.

This was referenced Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants