Skip to content

[3.0] Finish of the SecurityContext (follow-up pr) #15855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2015
Merged

[3.0] Finish of the SecurityContext (follow-up pr) #15855

merged 1 commit into from
Sep 22, 2015

Conversation

linaori
Copy link
Contributor

@linaori linaori commented Sep 21, 2015

Q A
Fixed tickets #12445
License MIT
Doc PR ~

Because the original PR was getting too big for pretty much nothing (everything was already done in smaller commits over time), I have opened just this PR to confirm the changes by adding it to the CHANGELOG.md files.

@@ -4,7 +4,7 @@ CHANGELOG
3.0.0
-----

* removed all deprecated codes from 2.x versions
* removed all deprecations from 2.x versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous message is better IMO. We removed the deprecate code, not just the deprecations themselves (which would mean un-deprecating the code)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about simply removed all deprecated code.?

@fabpot
Copy link
Member

fabpot commented Sep 22, 2015

Thank you @iltar.

@fabpot fabpot merged commit 351ebfc into symfony:master Sep 22, 2015
fabpot added a commit that referenced this pull request Sep 22, 2015
This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0] Finish of the SecurityContext (follow-up pr)

| Q             | A
| ------------- | ---
| Fixed tickets | #12445
| License       | MIT
| Doc PR        | ~

Because the original PR was getting too big for pretty much nothing (everything was already done in smaller commits over time), I have opened just this PR to confirm the changes by adding it to the CHANGELOG.md files.

Commits
-------

351ebfc Updated CHANGELOG
@linaori linaori deleted the feature/security-context-removal branch April 15, 2016 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants