[#13672] Re-adding default assets to FrameworkBundle #15871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We actually decided in #13800 to not add it by default. Instead, I'm going to add an explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13672, a default
assetsconfiguration was added toframework. Without this, if you don't haveassetsset, there are some consequences (like theAssetExtensionnot being loaded as a twig extension).This was removed at some point on the master branch. There's discussion on enabling less things in FrameworkBundle in general, but as this (so far) hasn't been marked as deprecated in 2.8, it shouldn't be removed in 3.0. Said differently, an alternative would be to deprecate relying on this default configuration in 2.8.
Thanks!