Forbid serializing a Crawler #15906
Merged
Forbid serializing a Crawler #15906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unserializing a Crawler instance creates DOM elements in an invalid state, making the Crawler unusable.
|
👍 Status: Reviewed |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Forbid serializing a Crawler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Unserializing a Crawler instance creates DOM elements in an invalid state, making the Crawler unusable. While working on #15849, I figured out that DomCrawler actually inherits ``Serializable`` from its ``SplObjectStorage`` parent, and so I tried to serialize and unserialize one. The answer is that it does not work. This is what happens when trying to call ``parents`` on it for instance: ``` Symfony\Component\DomCrawler\Crawler::parents(): Invalid State Error ``` Commits ------- 12733cb Forbid serializing a Crawler
This was referenced Oct 27, 2015
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unserializing a Crawler instance creates DOM elements in an invalid state, making the Crawler unusable.
While working on #15849, I figured out that DomCrawler actually inherits
Serializablefrom itsSplObjectStorageparent, and so I tried to serialize and unserialize one. The answer is that it does not work. This is what happens when trying to callparentson it for instance: