Skip to content

Removed the "Delete profiles" action from the web profiler sidebar #15939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2015
Merged

Removed the "Delete profiles" action from the web profiler sidebar #15939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ public function panelAction(Request $request, $token)
*/
public function purgeAction()
{
@trigger_error('The '.__METHOD__.' method is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED);

if (null === $this->profiler) {
throw new NotFoundHttpException('The profiler must be enabled.');
}
Expand Down
7 changes: 0 additions & 7 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/admin.html.twig
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@
{% endfor %}
</ul>
{% endif %}

<div class="module">
{{ include('@WebProfiler/Profiler/admin.html.twig', { token: token|default('') }, with_context = false) }}
</div>
</div>
</div>
</div>
Expand Down
21 changes: 0 additions & 21 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,32 +486,15 @@ tr.status-warning td {
padding-bottom: 99999px; {# needed for 'same-height columns' trick #}
width: 220px;
}
#sidebar a {
color: #ADD8E6;
}
#sidebar .module {
padding: 10px;
width: 220px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need this for the logout link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. In the toolbar we use .sf-toolbar-block .sf-toolbar-info-piece a. I've tried to make the toolbar and the profiler as independent as possible.

}
#sidebar .module h3 {
color: #999;
font-size: 12px;
font-weight: bold;
text-transform: uppercase;
margin-bottom: 10px;
}

{# Sidebar Shortcuts
------------------------------------------------------------------------- #}
#sidebar #sidebar-shortcuts {
background: #333;
/* needed to prevent visual issues due to the pure CSS slideToggle() */
-webkit-touch-callout: none;
-webkit-user-select: none;
-khtml-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
width: 220px;
}
#sidebar #sidebar-shortcuts .shortcuts {
Expand Down Expand Up @@ -567,10 +550,6 @@ tr.status-warning td {
float: right;
margin-right: 10px;
}
#sidebar-admin a {
font-size: 14px;
margin-left: 10px;
}

{# Sidebar Menu
------------------------------------------------------------------------- #}
Expand Down