Skip to content

Updated the style of the translation commands #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Updated the style of the translation commands #15969

wants to merge 4 commits into from

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@ogizanagi did a great job updating the styles of these commands. This is just a bit of tweaking here and there:

(Left = old; Right = new)

comparison_1

comparison_2

comparison_3

comparison_4

comparison_5

@fabpot
Copy link
Member

fabpot commented Sep 28, 2015

Can you reference the original PR?

@javiereguiluz
Copy link
Member Author

The original PR which was merged is #14595

@fabpot
Copy link
Member

fabpot commented Sep 28, 2015

👍

1 similar comment
@ogizanagi
Copy link
Contributor

👍

@fabpot
Copy link
Member

fabpot commented Sep 28, 2015

Needs the new output method before merging

@javiereguiluz javiereguiluz force-pushed the fix_translation_commands branch 2 times, most recently from 1f035ef to 09897d1 Compare September 30, 2015 10:33
@javiereguiluz javiereguiluz force-pushed the fix_translation_commands branch from 09897d1 to 1052b31 Compare October 1, 2015 08:28
@fabpot
Copy link
Member

fabpot commented Oct 1, 2015

Thank you @javiereguiluz.

@fabpot fabpot closed this in bee1faa Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @fabpot @ogizanagi @carsonbot