Skip to content

[Console] Updated the styles of the server commands #15972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR uses comment() which hasn't been merged yet. WIP PR at #15964

server_comparison_1

server_comparison_2

@javiereguiluz javiereguiluz changed the title [WCM] [Console] Updated the styles of the server commands [Console] Updated the styles of the server commands Sep 28, 2015
@fabpot
Copy link
Member

fabpot commented Sep 28, 2015

Thank you @javiereguiluz.

@fabpot fabpot closed this in d65f864 Sep 28, 2015
@@ -84,6 +85,8 @@ protected function configure()
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
$stdout = $output;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed. SymfonyStyle also implements OutputInterface. So it can be used just as $stdout.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, see below comment

@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants