remove api tags from code #15979
Merged
remove api tags from code #15979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tobion
commented
Sep 28, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15977 |
| License | MIT |
| Doc PR | n/a |
|
👍 but I think the first step is actually to update the doc, to stop telling users about the distinction |
494e8e5 to
f1c7c65
Compare
|
see symfony/symfony-docs#5735 for the docs changes |
|
👍 |
|
👍 I propose that you merge this PR and then merge it to 2.7/2.8/master, doing the needed addons; that would be much more efficient than doing a PR for each branch. |
Tobion
added a commit
that referenced
this pull request
Sep 29, 2015
This PR was merged into the 2.3 branch. Discussion ---------- remove api tags from code | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15977 | License | MIT | Doc PR | n/a Commits ------- f1c7c65 remove api tags from code
|
Merged in all branches. All api tags gone. |
|
\o/ |
|
What was the reason for this? |
|
I understand. 👍 |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 5, 2015
… and API classes (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Contributing][Code] do not distinguish regular classes and API classes | Q | A | ------------- | --- | Doc fix? | no | New docs? | kind of (symfony/symfony#15977, symfony/symfony#15979) | Applies to | all | Fixed tickets | Commits ------- 9794d58 do not distinguish regular classes and API classes
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 31, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Remove references to API tagging | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | n/a Related to symfony/symfony#15977 and symfony/symfony#15979. Commits ------- d816c7f Remove references to API tagging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.