Skip to content

[WebProfilerBundle] reflect latest changes in test #15981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 28, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

In #15973, the searchResultsAction() of the ProfilerController was
updated to pass the current request to the rendered template. However,
this change was not reflected in the test thus letting it fail.

In symfony#15973, the `searchResultsAction()` of the `ProfilerController` was
updated to pass the current request to the rendered template. However,
this change was not reflected in the test thus letting it fail.
@fabpot
Copy link
Member

fabpot commented Sep 28, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit ae283e8 into symfony:2.8 Sep 28, 2015
fabpot added a commit that referenced this pull request Sep 28, 2015
This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] reflect latest changes in test

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

In #15973, the `searchResultsAction()` of the `ProfilerController` was
updated to pass the current request to the rendered template. However,
this change was not reflected in the test thus letting it fail.

Commits
-------

ae283e8 [WebProfilerBundle] reflect latest changes in test
@xabbuh xabbuh deleted the fix-web-profiler-bundle-tests branch September 28, 2015 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants