Updated the styles of the container commands #15983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What finishing #15964? That would allow me to merge some of the PRs. |
60 tasks
|
fabbot has some good suggestions |
|
Fixed fabbot issues. |
892ed21 to
7d1deb1
Compare
|
Can you rebase as tests were badly broken where run? Thanks. |
7d1deb1 to
e93f6da
Compare
|
Rebased. |
|
There are some failing tests. |
|
I've fixed the tests (at least locally). |
| } | ||
| $tableRows[] = array('Tags', $tagInformation); | ||
|
|
||
| $tableRows[] = array('Scope', $definition->getScope()); |
There was a problem hiding this comment.
You should pass false to getScope to avoid the deprecation notice.
|
Thank you @javiereguiluz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses comment() which hasn't been merged yet. WIP PR at #15964
This command defines a lot of options, so I don't know if I've updated all the possible outputs: