Issue 13852 - Added omit_action option to form type #15995
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need a new option for this? Why not check for |
|
I agree with @1ed , a new option is not required for this. |
|
👎 Dislike a new option for a workaround. See #13852 (comment) for my proposal. |
|
I agree. Not rendering the attribute when it is empty sounds more sensible to me. |
|
Closing in favor of #16029 |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2015
… action attributes (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][TwigBridge] do not render empty form action attributes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13852, #15995 | License | MIT | Doc PR | Commits ------- 1307043 do not render empty form action attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply adds an
omit_actionoption toformType, which allows users to omit the action attribute from a rendered<form>element. According to the original issue #13852 this serves two purposes: 1. HTML5 forms who don't want to explicitly add an action will be valid (an emptyactionis not allowed in HTML5, and 2. Ajax forms and AngularJS will function without overriding theform_starttemplate.