Skip to content

[HttpKernel] removed deprecated profiler storages #16018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 30, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@Tobion
Copy link
Contributor

Tobion commented Sep 30, 2015

Tests are failing and you also need to remove code in https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L293

Status: Needs Work

@fabpot fabpot force-pushed the profiler-storage-engines-removal branch 3 times, most recently from bf32391 to 8694df4 Compare September 30, 2015 15:51
@fabpot
Copy link
Member Author

fabpot commented Sep 30, 2015

Just realized that lifetime should be deprecated as well. I'm going to create a PR on 2.8.

@fabpot
Copy link
Member Author

fabpot commented Sep 30, 2015

See #16027

@fabpot fabpot force-pushed the profiler-storage-engines-removal branch from 8694df4 to 2925df5 Compare October 1, 2015 05:55
@fabpot fabpot merged commit 2925df5 into symfony:master Oct 1, 2015
fabpot added a commit that referenced this pull request Oct 1, 2015
…pot)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[HttpKernel] removed deprecated profiler storages

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

2925df5 [HttpKernel] removed deprecated profiler storages
@fabpot fabpot mentioned this pull request Nov 16, 2015
@xavierleune
Copy link
Contributor

😢

xavierleune added a commit to xavierleune/symfony-docs that referenced this pull request Dec 16, 2015
The ProfilerStorage other than FileProfilerStorage have been removed in this PR : symfony/symfony#16018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants