[CssSelector] removed the deprecated CssSelector class #16020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Sep 30, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| } | ||
| } | ||
|
|
||
| public function getCssToXPathWithoutPrefixTestData() |
There was a problem hiding this comment.
I'm not sure all these tests where copied to the tests of the new class. It should be checked before removing them
There was a problem hiding this comment.
they are missing: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/CssSelector/Tests/CssSelectorConverterTest.php
also testParseExceptions
There was a problem hiding this comment.
tests have been updated with #16052
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Oct 1, 2015
Synchronizing the classes ensures that no tests are lost when the legacy API is removed in symfony#16020 for Symfony 3.0, thus mitigating the risk of future regressions.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Oct 1, 2015
Synchronizing the classes ensures that no tests are lost when the legacy API is removed in symfony#16020 for Symfony 3.0, thus mitigating the risk of future regressions.
fabpot
added a commit
that referenced
this pull request
Oct 1, 2015
…c API (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [CssSelector] synchronize tests for static and non-static API | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Synchronizing the classes ensures that no tests are lost when the legacy API is removed in #16020 for Symfony 3.0, thus mitigating the risk of future regressions. Commits ------- 2b29a40 synchronize tests for static and non-static API
fabpot
added a commit
that referenced
this pull request
Oct 1, 2015
… (fabpot) This PR was merged into the 3.0-dev branch. Discussion ---------- [CssSelector] removed the deprecated CssSelector class | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 3ffa422 [CssSelector] removed the deprecated CssSelector class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.