[3.0][Security] Remove deprecated features (follow up of #15899) #16035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a5b2bd to
090f0e8
Compare
| @@ -91,4 +75,9 @@ public function vote(TokenInterface $token, $object, array $attributes) | |||
|
|
|||
| return $result; | |||
| } | |||
|
|
|||
| private function supportsAttribute($attribute) | |||
There was a problem hiding this comment.
why not simply inline these conditions?
|
Status: Needs work |
| } | ||
| ``` | ||
|
|
||
| * The `AuthenticatedVoter::supportsClass()`, `ExpressionVoter::supportsClass()` and `RoleVoter::supportsClass()` |
There was a problem hiding this comment.
same should be said for all supportsAttribute() methods (even when they are private, they are no longer part of the public API)
5a24236 to
e2d859c
Compare
a93983f to
314fde6
Compare
314fde6 to
437398d
Compare
|
security tests pass ok |
|
Thank you @Koc. |
fabpot
added a commit
that referenced
this pull request
Oct 2, 2015
#15899) (Koc) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][Security] Remove deprecated features (follow up of #15899) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15899 | License | MIT | Doc PR | - - updated UPGRADE-3.0.md - removed unused `supportsClass` methods - changed visibility of `supportsAttribute` methods from public to private, removed `inheritdoc` annotation from them because there is no definition for this methods in parent interface - removed tests for `supportsClass` and `supportsAttribute` method - removed unused mock creation Commits ------- 437398d [3.0][Security] Remove deprecated features (follow up of #15899)
Merged
fabpot
added a commit
that referenced
this pull request
Jun 1, 2016
This PR was merged into the 2.8 branch. Discussion ---------- document method name changes in Voter class | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16035 | License | MIT | Doc PR | Commits ------- c0b9e99 document method name changes in Voter class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supportsClassmethodssupportsAttributemethods from public to private, removedinheritdocannotation from them because there is no definition for this methods in parent interfacesupportsClassandsupportsAttributemethod