[3.0] Remove more deprecated interfaces in Form and Validator #16067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 2, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| public function __construct(ContainerInterface $container, | ||
| array $typeServiceIds, array $typeExtensionServiceIds, | ||
| array $guesserServiceIds) | ||
| public function __construct(ContainerInterface $container, array $typeServiceIds, array $typeExtensionServiceIds, array $guesserServiceIds) |
There was a problem hiding this comment.
if this is done, then not only in master
There was a problem hiding this comment.
I will let @nicolas-grekas submit a PR for this on 2.3
02e85e2 to
a743fb6
Compare
|
👍 apart from the above comment |
| @@ -506,10 +505,6 @@ public function handleRequest($request = null) | |||
| */ | |||
| public function submit($submittedData, $clearMissing = true) | |||
| { | |||
| if ($submittedData instanceof Request) { | |||
| @trigger_error('Passing a Symfony\Component\HttpFoundation\Request object to the '.__CLASS__.'::bind and '.__METHOD__.' methods is deprecated since 2.3 and will be removed in 3.0. Use the '.__CLASS__.'::handleRequest method instead. If you want to test whether the form was submitted separately, you can use the '.__CLASS__.'::isSubmitted method.', E_USER_DEPRECATED); | |||
| } | |||
There was a problem hiding this comment.
We must also remove support for when a Request is passed, I don't see where it's done here.
There was a problem hiding this comment.
There is/was a listener that transforms the data.
There was a problem hiding this comment.
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 2, 2015
…lidator (nicolas-grekas) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] Remove more deprecated interfaces in Form and Validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- a743fb6 [3.0] Remove more deprecated interfaces in Form and Validator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.