Skip to content

fix validator test dependency #16086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2015
Merged

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Oct 2, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Fix test https://travis-ci.org/symfony/symfony/jobs/83308337#L3653 as property access is required for expression constraint.

@@ -25,6 +25,7 @@
"symfony/intl": "~2.8|~3.0",
"symfony/yaml": "~2.8|~3.0",
"symfony/config": "~2.8|~3.0",
"symfony/property-access": "~2.3|~3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ~2.8|~3.0

@nicolas-grekas
Copy link
Member

👍 with ~2.8|~3.0

@Tobion Tobion force-pushed the validator-access-dep branch from 0dcd5f7 to 3b7cb33 Compare October 2, 2015 17:46
@stof
Copy link
Member

stof commented Oct 2, 2015

👍

@fabpot
Copy link
Member

fabpot commented Oct 3, 2015

Thank you @Tobion.

@fabpot fabpot merged commit 3b7cb33 into symfony:master Oct 3, 2015
fabpot added a commit that referenced this pull request Oct 3, 2015
This PR was merged into the 3.0-dev branch.

Discussion
----------

fix validator test dependency

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fix test https://travis-ci.org/symfony/symfony/jobs/83308337#L3653 as property access is required for expression constraint.

Commits
-------

3b7cb33 fix validator test dependency
@Tobion Tobion deleted the validator-access-dep branch October 3, 2015 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants