[Process] Throw exception if tempnam returns false #16092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pierredup
commented
Oct 2, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15215 |
| License | MIT |
| Doc PR |
| @@ -52,8 +52,7 @@ public function __construct($disableOutput, $input) | |||
| Process::STDERR => tempnam(sys_get_temp_dir(), 'sf_proc_stderr'), | |||
There was a problem hiding this comment.
prefix
The prefix of the generated temporary filename.
Note: Windows uses only the first three characters of prefix.
So the prefix would be the same for stdout and stderr on windows, which defeats the purpose. I propose to change the prefix to be different, e.g. out and err
There was a problem hiding this comment.
I've changed this to use out_sf_proc and err_sf_proc as the prefix
2e93288 to
cc854e6
Compare
|
👍 |
|
For 2.3 the same would need to be applied in https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Process/ProcessPipes.php#L52 |
Tobion
added a commit
that referenced
this pull request
Oct 4, 2015
…pierredup) This PR was merged into the 2.3 branch. Discussion ---------- Throw exception if tempnam returns false in ProcessPipes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15215 | License | MIT | Doc PR | Related to #16092 Commits ------- 1425b8a Throw exception if tempnam returns false in ProcessPipes
|
Thank you @pierredup. |
Tobion
added a commit
that referenced
this pull request
Oct 4, 2015
…dup) This PR was merged into the 2.7 branch. Discussion ---------- [Process] Throw exception if tempnam returns false | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15215 | License | MIT | Doc PR | Commits ------- cc854e6 Throw exception if tempnam returns false
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.