temporarily allow PHP 7 builds to fail #16112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a pain to review pull requests that always fail as the build job for PHP 7 is broken. We have to use PHPUnit 5 for this job as it is the only version supporting PHP 7 which suffers from broken behavior in the mock library (see sebastianbergmann/phpunit-mock-objects#259). Therefore, I suggest to allow failures of the PHP 7 build job until above mentioned issue has been fixed to make it easier for reviewers to spot really broken tests.
|
👍 |
|
Can't we fix the issue instead? |
|
As far as I understand the issue this must be fixed in PHPUnit's mock library. |
|
Yes, that's were I meant to fix the issue, this is oss :-) |
|
As far as I tested correctly, the issue is in the 4.8 version: |
|
So, spending a few minutes on this, I'm for now 👎 for allowing the failure and 👍 for understanding what's going on in phpunit... |
|
That's an interesting observation and I agree with you then. Thanks for investigating. We can reopen here anyway if we don't succeed soon enough. |
This was referenced Oct 5, 2015
|
So: the issue comes from an unchecked assertion in phpunit 4 that has been fixed in 5.0 as part of sebastianbergmann/phpunit#1821 |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 6, 2015
…/phpunit#1821 (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16112 | License | MIT | Doc PR | - See sebastianbergmann/phpunit#1821 Commits ------- 742547c [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a pain to review pull requests that always fail as the build job
for PHP 7 is broken. We have to use PHPUnit 5 for this job as it is the
only version supporting PHP 7 which suffers from broken behavior in the
mock library (see sebastianbergmann/phpunit-mock-objects#259).
Therefore, I suggest to allow failures of the PHP 7 build job until
above mentioned issue has been fixed to make it easier for reviewers to
spot really broken tests.