Replace is_callable checks with type hints #16125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes tests checking the exceptions thrown from the removed is_callable checks.
4 tasks
|
This is the same BC break as in ##14330. You get a warning for overwritten method that the signature is not the same: https://3v4l.org/ruPcK But I'm 👍 to add callable typehints. |
|
@Tobion in this PR, it is OK:
|
|
@nicolas-grekas and it would be great to fix the deps=low tests of the Translation component |
| */ | ||
| public function __construct($caster, \Exception $prev) | ||
| public function __construct(\Exception $prev) |
There was a problem hiding this comment.
shouldn't this be changed in older branches actually ?
|
👍 Status: Reviewed |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
…nicolas-grekas) This PR was merged into the 3.0-dev branch. Discussion ---------- Replace is_callable checks with type hints | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14330 | License | MIT | Doc PR | - Also removes tests checking the exceptions thrown from the removed is_callable checks. Commits ------- 7685cdd Add more callable type hints 4e0c6e1 Replace is_callable checks with type hints
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes tests checking the exceptions thrown from
the removed is_callable checks.