[VarDumper] consistent signature of getDump() in class + trait #16147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 6, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16126 |
| License | MIT |
| Doc PR |
| @@ -29,7 +29,7 @@ public function assertDumpMatchesFormat($dump, $data, $message = '') | |||
| $this->assertStringMatchesFormat(rtrim($dump), $this->getDump($data), $message); | |||
| } | |||
|
|
|||
| private function getDump($data) | |||
| public function getDump($data) | |||
There was a problem hiding this comment.
@nicolas-grekas Wouldn't it be enough to have the method protected in both the class and the trait?
There was a problem hiding this comment.
alright, I changed both methods
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
… trait (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] consistent signature of getDump() in class + trait | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16126 | License | MIT | Doc PR | Commits ------- 48a9e83 consistent signature of getDump() in class + trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.