[HttpFoundation] Fixes /0 subnet handling in IpUtils #16177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| array(true, '192.168.1.1', array('1.2.3.4/1', '192.168.1.0/24')), | ||
| array(true, '192.168.1.1', array('192.168.1.0/24', '1.2.3.4/1')), | ||
| array(false, '192.168.1.1', array('1.2.3.4/1', '4.3.2.1/1')), | ||
| array(true, '1.2.3.4', '0.0.0.0/0'), |
There was a problem hiding this comment.
The case verifying 1.2.3.4 is in subnet 192.168.1.0/0 covers this code path, but I'll add it back anyway.
|
The AppVeyor build seems to have failed for reasons unrelated to this pull request - the Travis build passed which includes the unit tests I updated. Do all of the checks need to pass before the pull request can be merged, even if unrelated to this PR? |
|
Don't we have the same issue for the IPv6 check? |
This was referenced Oct 13, 2015
Closed
|
Thank you @ultrafez. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2015
…afez) This PR was squashed before being merged into the 2.3 branch (closes #16177). Discussion ---------- [HttpFoundation] Fixes /0 subnet handling in IpUtils | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16055 | License | MIT | Doc PR | Not needed Fixes bug #16055. For IP addresses with CIDR subnet length 0, the IP address must be valid - IPs with subnet masks greater than zero are implicitly validated due to the use of `ip2long` and `substr_compare` (although it's not particularly robust - there could be some future work to improve this here). Commits ------- d9ac571 [HttpFoundation] Fixes /0 subnet handling in IpUtils
This was referenced Oct 27, 2015
Closed
Merged
Merged
|
Yes, there is the same issue with IPv6 addresses - I'm not as familiar with them as I am with IPv4, but if I get a chance I'll take a look and submit it as a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #16055. For IP addresses with CIDR subnet length 0, the IP address must be valid - IPs with subnet masks greater than zero are implicitly validated due to the use of
ip2longandsubstr_compare(although it's not particularly robust - there could be some future work to improve this here).