Skip to content

Fix missing deprecation notice for type #16232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2015
Merged

Fix missing deprecation notice for type #16232

merged 2 commits into from
Oct 16, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 13, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Replaces #16231

@wouterj wouterj mentioned this pull request Oct 13, 2015
Closed
@nicolas-grekas
Copy link
Member

Cool, many thanks!
You may have to raise a few lowest versions in composer.json files isn't it?

@wouterj
Copy link
Member Author

wouterj commented Oct 13, 2015

Afaics, all dependencies are correct. Something seems wrong if we set type instead of entry_type (entry_type will get the normal default value instead of inheriting the one from type). I'm not sure why occurs in HHVM and PHP 5.3 and 7...

@stof
Copy link
Member

stof commented Oct 14, 2015

@wouterj this is because the type normalizer is broken. It misses the return statement, meaning it always return null for the option

@stof
Copy link
Member

stof commented Oct 14, 2015

and the reason why only these jobs are broken is clear:

  • 5.4 and 5.5 are not running tests for PRs to make builds faster
  • 5.6 is running deps=high, which does not run legacy tests, and the issue is in a legacy test

@wouterj wouterj force-pushed the nicolas-grekas-fix-miss branch from c1d01c6 to 27517e3 Compare October 15, 2015 10:38
@wouterj
Copy link
Member Author

wouterj commented Oct 15, 2015

Thanks @stof for the explanation.

Tests pass now (appveyor failure seems to be unrelated).

@fabpot
Copy link
Member

fabpot commented Oct 16, 2015

Thank you @wouterj.

@fabpot fabpot merged commit 27517e3 into symfony:2.8 Oct 16, 2015
fabpot added a commit that referenced this pull request Oct 16, 2015
@fabpot
bug #16232 Fix missing deprecation notice for type (nicolas-grekas,…
72c6c61 
… WouterJ)

This PR was merged into the 2.8 branch.

Discussion
----------

Fix missing deprecation notice for `type`

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Replaces #16231

Commits
-------

27517e3 Use entry_type instead of type
87fdffa [Form] Fix missing notice for deprecated `type`
@wouterj wouterj deleted the nicolas-grekas-fix-miss branch October 16, 2015 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @nicolas-grekas @stof @fabpot @carsonbot