[Validator] Allow an empty path in a URL with only a fragment or a query #16259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Oct 17, 2015
…ent or a query (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Allow an empty path in a URL with only a fragment or a query | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15891 | License | MIT | Doc PR | - URLs like `http://symfony.com?query=1` or `http://symfony.com#` should be valid. According to the [RFC3986](https://tools.ietf.org/html/rfc3986#page-16): > When authority is present, the path must either be empty or begin with a slash ("/") character. > When authority is not present, the path cannot begin with two slash characters ("//"). Since the RFC describes URIs, the second sentence doesn't apply here as the authority is required in URLs . Commits ------- b3a5411 [Validator] Allow an empty path in a URL with only a fragment or a query
This was referenced Oct 27, 2015
Closed
Merged
Merged
|
@jakzal Can you double check your changes? But this test case failed |
fabpot
added a commit
that referenced
this pull request
Nov 13, 2015
…or a query (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Allow an empty path with a non empty fragment or a query | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16536 | License | MIT | Doc PR | - #16259 didn't fully fix the issue. Commits ------- 2d0af8e [Validator] Allow an empty path with a non empty fragment or a query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs like
http://symfony.com?query=1orhttp://symfony.com#should be valid.According to the RFC3986:
Since the RFC describes URIs, the second sentence doesn't apply here as the authority is required in URLs .