[TwigBundle] Fix Twig cache is not properly warmed #16262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4fded7 to
1aa9788
Compare
| @@ -34,7 +34,7 @@ class TemplateCacheCacheWarmer implements CacheWarmerInterface | |||
| * @param ContainerInterface $container The dependency injection container | |||
| * @param TemplateFinderInterface $finder The template paths cache warmer | |||
There was a problem hiding this comment.
|null and please add explanation why null it allowed
|
What I don't get is why are templates not beeing warmed if the templating component is not used? I mean we have the goal to use twig without templating, but the warmup should still compile all templates ideally, or not? |
1aa9788 to
e704ee4
Compare
|
👍 |
|
@Tobion That's not the purpose of this PR but to answer your question: simply because nobody ever implemented it. In the past, it was not really needed as the templating component was mandatory. Now that it's not anymore, we need another cache warmer (I will submit a PR this week-end to fill the gap). |
|
👍 |
|
Thank you @tucksaun. |
fabpot
added a commit
that referenced
this pull request
Oct 17, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [TwigBundle] Fix Twig cache is not properly warmed | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15982 | License | MIT | Doc PR | - Alternative to #15034 Commits ------- e704ee4 [TwigBundle] Fix Twig cache is not properly warmed
fabpot
added a commit
that referenced
this pull request
Oct 19, 2015
…ting is disabled (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [TwigBundle] added a Twig templates warmer when templating is disabled | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When disabling the templating component, Twig templates are not warmed up as the warmer depends on the template finder which needs the templating component. This PR adds a new cache warmer that covers this case. see #16262 Commits ------- bd3701b [TwigBundle] added a Twig templates warmer when templating is disabled
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #15034