Skip to content

Fixed dumpArray when passing an empty array #16267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 16, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #16266
License MIT
Doc PR -

@nerdstein
Copy link

@wouterj is there a way to get this applied to the 2.8.* branch?

@wouterj
Copy link
Member Author

wouterj commented Oct 16, 2015

@nerdstein when this PR is merged, the code from 2.3 is merged into 2.7 and 2.8 and will be included in the next 2.8 release.

@fabpot
Copy link
Member

fabpot commented Oct 17, 2015

@wouterj Can you add a test?

@fabpot
Copy link
Member

fabpot commented Oct 17, 2015

👍

@wouterj
Copy link
Member Author

wouterj commented Oct 17, 2015

Done

@wouterj wouterj force-pushed the patch-18 branch 2 times, most recently from 4af6002 to ded0ce1 Compare October 17, 2015 09:20
@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

In the past, a change like this was rejected as we do not really know if the PHP array really was supposed to be a sequence or a mapping (see for example #9870). And this would also mean to break applications that rely on the current behaviour.

@fabpot
Copy link
Member

fabpot commented Jan 25, 2016

hmm, @xabbuh is right, closing then.

@fabpot fabpot closed this Jan 25, 2016
@xabbuh
Copy link
Member

xabbuh commented Jan 25, 2016

Maybe we should introduce dumper options to let people do this (see #17520).

@wouterj wouterj deleted the patch-18 branch January 25, 2016 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants