-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Fixed dumpArray when passing an empty array #16267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wouterj
commented
Oct 16, 2015
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #16266 |
License | MIT |
Doc PR | - |
@wouterj is there a way to get this applied to the 2.8.* branch? |
@nerdstein when this PR is merged, the code from 2.3 is merged into 2.7 and 2.8 and will be included in the next 2.8 release. |
@wouterj Can you add a test? |
👍 |
Done |
4af6002
to
ded0ce1
Compare
In the past, a change like this was rejected as we do not really know if the PHP array really was supposed to be a sequence or a mapping (see for example #9870). And this would also mean to break applications that rely on the current behaviour. |
hmm, @xabbuh is right, closing then. |
Maybe we should introduce dumper options to let people do this (see #17520). |