Unify URL generator reference type + make linking in php templates consistent with twig #16276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Oct 18, 2015
This PR was squashed before being merged into the 2.3 branch (closes #16277). Discussion ---------- [Routing] use constants in tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Use constants in tests instead of hardcoded values in preparation for #16276 Commits ------- 608c8d2 [Routing] use constants in tests
|
👍 |
… line with twig templates
…s cumbersome to use constants in templates
22b777d to
388fa43
Compare
|
Rebased |
|
👍 Status: Reviewed |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2015
…hp templates consistent with twig (Tobion) This PR was merged into the 2.8 branch. Discussion ---------- Unify URL generator reference type + make linking in php templates consistent with twig | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #14672 | License | MIT | Doc PR | TODO Please see ticket. Please merge #16277 first. I will then rebase this to make tests pass. Commits ------- 388fa43 [Templating] deprecate low-level RouterHelper::generate method as it's cumbersome to use constants in templates 97d6828 [Templating] introduce path and url methods in php templates to be in line with twig templates 912fc4d [Routing] deprecate the old url generator reference type values
This was referenced Oct 20, 2015
|
see symfony/symfony-docs#5813 and symfony/symfony-docs#5814 for the documentation update |
craue
added a commit
to craue/CraueConfigBundle
that referenced
this pull request
Oct 20, 2015
…on warnings while running tests see symfony/symfony#16276
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 5, 2015
This PR was merged into the 2.3 branch. Discussion ---------- use constants to choose generated URL type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | symfony/symfony#16276 Commits ------- f00efff use constants to choose generated URL type
Merged
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 30, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Use path() and url() PHP templating helpers | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#16276) | Applies to | 2.8+ | Fixed tickets | #5814 Commits ------- a4ad744 Use path() and url() PHP templating helpers
craue
added a commit
to craue/CraueFormFlowBundle
that referenced
this pull request
Dec 1, 2015
…on warnings while running tests see symfony/symfony#16276
craue
added a commit
to craue/CraueFormFlowBundle
that referenced
this pull request
Dec 1, 2015
…on warnings while running tests see symfony/symfony#16276
craue
added a commit
to craue/CraueFormFlowBundle
that referenced
this pull request
Dec 1, 2015
…on warnings while running tests see symfony/symfony#16276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see ticket.
Please merge #16277 first. I will then rebase this to make tests pass.